579374 - Tooltip border is inconsistent when one is used on a web element.

Status: VERIFIED FIXED

(Core :: Layout, defect, P5)

Description

[Shane Bundy]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 5.1; en-US; rv:2.0b2pre) Gecko/20100716 Minefield/4.0b2pre
Build Identifier: Mozilla/5.0 (Windows; Windows NT 5.1; en-US; rv:2.0b2pre) Gecko/20100716 Minefield/4.0b2pre

When I was mousing over one of the bot labels (green, orange or red) I noticed the tooltip border was broken along the edges. It is the same missing pixels no matter what I moused over.

Reproducible: Always

Steps to Reproduce:
On the provided URL, mouse over one of the bot labels next to any of the OSes (e.g. Bd, Bo, etc.)
Actual Results:  
Notice the tooltip has pixels missing from its border.

Expected Results:  
The border should be complete.

Does not happen within the browser UI.

Comment 1

[Alice0775 White]

Works;
http://hg.mozilla.org/mozilla-central/rev/92339b84d089
Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; en-US; rv:2.0b2pre) Gecko/20100715 Minefield/4.0b2pre ID:20100715145415

fails;
http://hg.mozilla.org/mozilla-central/rev/e1d7fd5255fd
Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; en-US; rv:2.0b2pre) Gecko/20100715 Minefield/4.0b2pre ID:20100715152722

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=92339b84d089&tochange=e1d7fd5255fd

Comment 2

[Daniel Veditz [:dveditz]]

If this is a recent trunk regression I don't see how it blocks old branches

Comment 3

[Shane Bundy]

Attachment: Screen capture of tooltip

Comment 4

[Shane Bundy]

Attachment: Another test case

Here is another test case but from Bugzilla.

Comment 5

[Shane Bundy]

(In reply to comment #4)
> Created attachment 457961 [details]
> Another test case
> 
> Here is another test case but from Bugzilla.

That example has artifacts from the page around the tooltip. My bad.

Comment 6

[pal-moz]

Attachment: screenshot

(In reply to comment #0)
> Does not happen within the browser UI.

happen on tooltip for tab, back/forward button, home button... all tooltip.

Windows 7.

Comment 7

[Shane Bundy]

@pal-moz - Confirmed. At first I didn't notice it but on closer inspection it has the same tooltip problem. Thank you for pointing that out for me.

Comment 8

[Shane Bundy]

It doesn't happen to the tooltips on the bookmark toolbar or the 'new tab' tooltip. Very odd. :-/

Comment 9

[Andreas Jung]

Every tooltip that contains only one line of text is displayed with a broken border.
Tooltips that contain multiple lines of text are displayed fine.

Therefore the tooltips of bookmarks are displayed correctly - they always contain two lines of text.
The 'new tab' tooltip is odd - it only contains one line of text, but is displayed correct anyway.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

It appears that the size of previous tooltips is being remembered, which is the source of the weirdness. Try hovering over multiple Bugzilla links in a depends list and notice how the the larger ones show glitches near where the edges of the smaller ones were.

Comment 13

[Christopher Correa]

It happens to me, too, when I have Direct2D and DirectWrite enabled.

Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100726 Minefield/4.0b3pre

Comment 14

[Shane Bundy]

'New tab' button is now affected by this issue.

Comment 15

[Shane Bundy]

(In reply to comment #14)

In the 27/07/2010 trunk build, the 'new tab' tooltip is no longer affected. (?)

Comment 16

[Slavic]

(In reply to comment #15)
> (In reply to comment #14)
> 
> In the 27/07/2010 trunk build, the 'new tab' tooltip is no longer affected. (?)

I still see this bug exactly as before on Minefield 4.0b3pre (x64 version, 20100728).

Comment 17

[Kai de Leeuw]

I think this is a regression from the "retain layers and layer contents" check-in, bug 564991.

Comment 18

[Kai de Leeuw]

doh... now I see this issue is already blocking that issue. Sorry...

Comment 19

[Shane Bundy]

It appears to be fixed on Windows 7 when the Win7 theme is used. I'm unsure if it still occurs on XP or when the Windows Classic theme is used.

Comment 20

[Slavic]

Not yet fixed in Beta 4 on Windows XP with classic theme.

Comment 21

[Slavic]

Apparently fixed in Firefox 4.0 beta 5 build 1, as I see using Windows Classic.

Comment 22

[Dave Garrett]

I'm still seeing this in Firefox 4.0 beta 5 build 1 on Linux. I don't know if that means it's fixed for Windows or your setup or isn't really fixed.

Comment 23

[Shane Bundy]

So this is fixed on Windows (somehow) but I guess Linux still has this problem. Any word on Mac yet?

Comment 24

[Timothy Nikkel (:tnikkel)]

Finding out when and what fixed this on Windows might be helpful to fixing this on Linux.

Comment 25

[pal-moz]

(In reply to comment #24)
> Finding out when and what fixed this on Windows might be helpful to fixing this
> on Linux.

maybe fixed range is between 2010-08-19-10 and 2010-08-20-04

Comment 26

[Alice0775 White]

I have a different range with force enable D2D.
user_pref("gfx.font_rendering.directwrite.enabled",true);
user_pref("gfx.direct2d.force-enabled", true);

Broken:
http://hg.mozilla.org/mozilla-central/rev/17f4064c1d23
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100813 Minefield/4.0b4pre ID:20100813230431
Fixed:
http://hg.mozilla.org/mozilla-central/rev/536ac334d335
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100813 Minefield/4.0b4pre ID:20100814003550
Fixed range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=17f4064c1d23&tochange=536ac334d335

Comment 27

[Alice0775 White]

And In Windows XP Classc Style(Disabled D2D)
Broken:
http://hg.mozilla.org/mozilla-central/rev/c7b53c12191b
Mozilla/5.0 (Windows NT 5.1; rv:2.0b5pre) Gecko/20100819 Minefield/4.0b5pre ID:20100819210405
Fixed:
http://hg.mozilla.org/mozilla-central/rev/9976121e4d31
Mozilla/5.0 (Windows NT 5.1; rv:2.0b5pre) Gecko/20100819 Minefield/4.0b5pre ID:20100819215122
Fixed Range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c7b53c12191b&tochange=9976121e4d31

Comment 28

[pal-moz]

(In reply to comment #25)
> (In reply to comment #24)
> > Finding out when and what fixed this on Windows might be helpful to fixing this
> > on Linux.
> 
> maybe fixed range is between 2010-08-19-10 and 2010-08-20-04

is on XP with Luna theme. (all HW acceleration OFF)

Comment 29

[Timothy Nikkel (:tnikkel)]

Thanks for that. If we do the approximately same thing on Linux as those changesets do for Windows the bug is fixed.

Comment 30

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You mean you have a patch that fixes this? Can you take this bug then? :-)

Comment 31

[Timothy Nikkel (:tnikkel)]

I just blindly ported http://hg.mozilla.org/mozilla-central/rev/2f75f983440c to Linux, someone who knows what is actually going on should write the patch.

Comment 32

[Dave Garrett]

Can someone on Mac please report if this bug is down to Linux specific? Is Mac (still) affected too? Shane asked above but no one has said yet if Mac needs a fix here too, or it's unaffected.

Comment 35

[Hideo Oshima]

I can't reproduce with recent Linux build.
Is this fixed by bug 615794?

Comment 36

[Ilja Sekler]

(In reply to comment #35)
> I can't reproduce with recent Linux build.

I still see the issue with a Firefox build from <http://hg.mozilla.org/mozilla-central/rev/df3c1150dd7a>.

Comment 37

[Alice0775 White]

Attachment: screenshot

I can reproduce.
http://hg.mozilla.org/mozilla-central/rev/8f1c39add00f
Mozilla/5.0 (X11; Linux i686; rv:2.0b9pre) Gecko/20110108 Firefox/4.0b9pre ID:20110108030351

Comment 38

[Hideo Oshima]

I was wrong.
It's still reproduce for me too.
Sorry for the spam.

Comment 39

[(no longer active)]

Attachment: Patch (v1)

Comment 40

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/e874889e43d1

Comment 41

[u279076]

Verified fixed with Firefox 4.0b11build3